On 21/12/2023 13:28, Raphael Gallais-Pou wrote:
> Add dt-binding file for "st,stm32-lvds" compatible.
>
A nit, subject: drop second/last, redundant "dt-bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
> Signed-off-by: Raphael Gallais-Pou <raphael.gallais-pou@xxxxxxxxxxx>
> ---
> .../bindings/display/st,stm32-lvds.yaml | 114 ++++++++++++++++++
> 1 file changed, 114 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/st,stm32-lvds.yaml
>
...
> +properties:
> + "#clock-cells":
> + const: 0
> +
> + compatible:
> + const: st,stm32-lvds
Please put compatible as first.
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: APB peripheral clock
> + - description: Reference clock for the internal PLL
> +
> + clock-names:
> + items:
> + - const: pclk
> + - const: ref
> +
> + resets:
> + maxItems: 1
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: |
> + LVDS input port node, connected to the LTDC RGB output port.
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: |
> + LVDS output port node, connected to a panel or bridge input port.
Ports are not required? I would assume it won't work without input and
output.
> +
> +required:
> + - "#clock-cells"
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - resets
> + - ports
> +
> +unevaluatedProperties: false
additionalProperties instead... or did I miss some $ref anywhere?
> +
> +examples:
> + - |
> + #include <dt-bindings/bus/stm32mp25_sys_bus.h>
> + #include <dt-bindings/clock/stm32mp25-clks.h>
> + #include <dt-bindings/reset/stm32mp25-resets.h>
> +
> + lvds: lvds@48060000 {
> + #clock-cells = <0>;
> + compatible = "st,stm32-lvds";
compatible is always the first property.
> + reg = <0x48060000 0x2000>;
put clock-cells here
> + clocks = <&rcc CK_BUS_LVDS>, <&rcc CK_KER_LVDSPHY>;
> + clock-names = "pclk", "ref";
> + resets = <&rcc LVDS_R>;
Best regards,
Krzysztof
