Re: [PATCH v3 1/4] drm/i915/gt: Create the gt_to_guc() wrapper

[Nirmoy Das <nirmoy.das@xxxxxxxxx>]

On 12/6/2023 9:46 PM, Andi Shyti wrote:
> We already have guc_to_gt() and getting to guc from the GT it
> requires some mental effort. Add the gt_to_guc().
>
> Given the reference to the "gt", the gt_to_guc() will return the
> pinter to the "guc".
>
> Update all the files under the gt/ directory.
>
> Signed-off-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
Reviewed-by: Nirmoy Das <nirmoy.das@xxxxxxxxx>
> ---
>   drivers/gpu/drm/i915/gt/intel_engine_cs.c     | 4 ++--
>   drivers/gpu/drm/i915/gt/intel_ggtt.c          | 9 +++------
>   drivers/gpu/drm/i915/gt/intel_gt.h            | 5 +++++
>   drivers/gpu/drm/i915/gt/intel_gt_irq.c        | 6 +++---
>   drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 2 +-
>   drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c   | 8 ++++----
>   drivers/gpu/drm/i915/gt/intel_rc6.c           | 4 ++--
>   drivers/gpu/drm/i915/gt/intel_rps.c           | 2 +-
>   drivers/gpu/drm/i915/gt/intel_tlb.c           | 2 +-
>   drivers/gpu/drm/i915/gt/selftest_slpc.c       | 6 +++---
>   10 files changed, 25 insertions(+), 23 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> index 40687806d22a..bede7f09d4af 100644
> --- a/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_engine_cs.c
> @@ -589,7 +589,7 @@ u64 intel_clamp_preempt_timeout_ms(struct intel_engine_cs *engine, u64 value)
>   	 * NB: The GuC API only supports 32bit values. However, the limit is further
>   	 * reduced due to internal calculations which would otherwise overflow.
>   	 */
> -	if (intel_guc_submission_is_wanted(&engine->gt->uc.guc))
> +	if (intel_guc_submission_is_wanted(gt_to_guc(engine->gt)))
>   		value = min_t(u64, value, guc_policy_max_preempt_timeout_ms());
>   
>   	value = min_t(u64, value, jiffies_to_msecs(MAX_SCHEDULE_TIMEOUT));
> @@ -610,7 +610,7 @@ u64 intel_clamp_timeslice_duration_ms(struct intel_engine_cs *engine, u64 value)
>   	 * NB: The GuC API only supports 32bit values. However, the limit is further
>   	 * reduced due to internal calculations which would otherwise overflow.
>   	 */
> -	if (intel_guc_submission_is_wanted(&engine->gt->uc.guc))
> +	if (intel_guc_submission_is_wanted(gt_to_guc(engine->gt)))
>   		value = min_t(u64, value, guc_policy_max_exec_quantum_ms());
>   
>   	value = min_t(u64, value, jiffies_to_msecs(MAX_SCHEDULE_TIMEOUT));
> diff --git a/drivers/gpu/drm/i915/gt/intel_ggtt.c b/drivers/gpu/drm/i915/gt/intel_ggtt.c
> index 21a7e3191c18..aa1e9249d393 100644
> --- a/drivers/gpu/drm/i915/gt/intel_ggtt.c
> +++ b/drivers/gpu/drm/i915/gt/intel_ggtt.c
> @@ -230,11 +230,8 @@ static void guc_ggtt_ct_invalidate(struct intel_gt *gt)
>   	struct intel_uncore *uncore = gt->uncore;
>   	intel_wakeref_t wakeref;
>   
> -	with_intel_runtime_pm_if_active(uncore->rpm, wakeref) {
> -		struct intel_guc *guc = &gt->uc.guc;
> -
> -		intel_guc_invalidate_tlb_guc(guc);
> -	}
> +	with_intel_runtime_pm_if_active(uncore->rpm, wakeref)
> +		intel_guc_invalidate_tlb_guc(gt_to_guc(gt));
>   }
>   
>   static void guc_ggtt_invalidate(struct i915_ggtt *ggtt)
> @@ -245,7 +242,7 @@ static void guc_ggtt_invalidate(struct i915_ggtt *ggtt)
>   	gen8_ggtt_invalidate(ggtt);
>   
>   	list_for_each_entry(gt, &ggtt->gt_list, ggtt_link) {
> -		if (intel_guc_tlb_invalidation_is_available(&gt->uc.guc))
> +		if (intel_guc_tlb_invalidation_is_available(gt_to_guc(gt)))
>   			guc_ggtt_ct_invalidate(gt);
>   		else if (GRAPHICS_VER(i915) >= 12)
>   			intel_uncore_write_fw(gt->uncore,
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt.h b/drivers/gpu/drm/i915/gt/intel_gt.h
> index b0e453e27ea8..d7c859039828 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt.h
> +++ b/drivers/gpu/drm/i915/gt/intel_gt.h
> @@ -118,6 +118,11 @@ static inline struct intel_gt *gsc_to_gt(struct intel_gsc *gsc)
>   	return container_of(gsc, struct intel_gt, gsc);
>   }
>   
> +static inline struct intel_guc *gt_to_guc(struct intel_gt *gt)
> +{
> +	return &gt->uc.guc;
> +}
> +
>   void intel_gt_common_init_early(struct intel_gt *gt);
>   int intel_root_gt_init_early(struct drm_i915_private *i915);
>   int intel_gt_assign_ggtt(struct intel_gt *gt);
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_irq.c b/drivers/gpu/drm/i915/gt/intel_gt_irq.c
> index 77fb57223465..ad4c51f18d3a 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_irq.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_irq.c
> @@ -68,9 +68,9 @@ gen11_other_irq_handler(struct intel_gt *gt, const u8 instance,
>   	struct intel_gt *media_gt = gt->i915->media_gt;
>   
>   	if (instance == OTHER_GUC_INSTANCE)
> -		return guc_irq_handler(&gt->uc.guc, iir);
> +		return guc_irq_handler(gt_to_guc(gt), iir);
>   	if (instance == OTHER_MEDIA_GUC_INSTANCE && media_gt)
> -		return guc_irq_handler(&media_gt->uc.guc, iir);
> +		return guc_irq_handler(gt_to_guc(media_gt), iir);
>   
>   	if (instance == OTHER_GTPM_INSTANCE)
>   		return gen11_rps_irq_handler(&gt->rps, iir);
> @@ -442,7 +442,7 @@ void gen8_gt_irq_handler(struct intel_gt *gt, u32 master_ctl)
>   		iir = raw_reg_read(regs, GEN8_GT_IIR(2));
>   		if (likely(iir)) {
>   			gen6_rps_irq_handler(&gt->rps, iir);
> -			guc_irq_handler(&gt->uc.guc, iir >> 16);
> +			guc_irq_handler(gt_to_guc(gt), iir >> 16);
>   			raw_reg_write(regs, GEN8_GT_IIR(2), iir);
>   		}
>   	}
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> index 7114c116e928..37e8d50c99ed 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c
> @@ -538,7 +538,7 @@ static bool rps_eval(void *data)
>   {
>   	struct intel_gt *gt = data;
>   
> -	if (intel_guc_slpc_is_used(&gt->uc.guc))
> +	if (intel_guc_slpc_is_used(gt_to_guc(gt)))
>   		return false;
>   	else
>   		return HAS_RPS(gt->i915);
> diff --git a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c
> index f0dea54880af..8b7813cac33e 100644
> --- a/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c
> +++ b/drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c
> @@ -456,7 +456,7 @@ static ssize_t slpc_ignore_eff_freq_show(struct kobject *kobj,
>   					 char *buff)
>   {
>   	struct intel_gt *gt = intel_gt_sysfs_get_drvdata(kobj, attr->attr.name);
> -	struct intel_guc_slpc *slpc = &gt->uc.guc.slpc;
> +	struct intel_guc_slpc *slpc = &gt_to_guc(gt)->slpc;
>   
>   	return sysfs_emit(buff, "%u\n", slpc->ignore_eff_freq);
>   }
> @@ -466,7 +466,7 @@ static ssize_t slpc_ignore_eff_freq_store(struct kobject *kobj,
>   					  const char *buff, size_t count)
>   {
>   	struct intel_gt *gt = intel_gt_sysfs_get_drvdata(kobj, attr->attr.name);
> -	struct intel_guc_slpc *slpc = &gt->uc.guc.slpc;
> +	struct intel_guc_slpc *slpc = &gt_to_guc(gt)->slpc;
>   	int err;
>   	u32 val;
>   
> @@ -587,7 +587,7 @@ static ssize_t media_freq_factor_show(struct kobject *kobj,
>   				      char *buff)
>   {
>   	struct intel_gt *gt = intel_gt_sysfs_get_drvdata(kobj, attr->attr.name);
> -	struct intel_guc_slpc *slpc = &gt->uc.guc.slpc;
> +	struct intel_guc_slpc *slpc = &gt_to_guc(gt)->slpc;
>   	intel_wakeref_t wakeref;
>   	u32 mode;
>   
> @@ -618,7 +618,7 @@ static ssize_t media_freq_factor_store(struct kobject *kobj,
>   				       const char *buff, size_t count)
>   {
>   	struct intel_gt *gt = intel_gt_sysfs_get_drvdata(kobj, attr->attr.name);
> -	struct intel_guc_slpc *slpc = &gt->uc.guc.slpc;
> +	struct intel_guc_slpc *slpc = &gt_to_guc(gt)->slpc;
>   	u32 factor, mode;
>   	int err;
>   
> diff --git a/drivers/gpu/drm/i915/gt/intel_rc6.c b/drivers/gpu/drm/i915/gt/intel_rc6.c
> index 7090e4be29cb..ee14d376ca7b 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rc6.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rc6.c
> @@ -109,7 +109,7 @@ static void gen11_rc6_enable(struct intel_rc6 *rc6)
>   	 * thus allowing GuC to control RC6 entry/exit fully instead.
>   	 * We will not set the HW ENABLE and EI bits
>   	 */
> -	if (!intel_guc_rc_enable(&gt->uc.guc))
> +	if (!intel_guc_rc_enable(gt_to_guc(gt)))
>   		rc6->ctl_enable = GEN6_RC_CTL_RC6_ENABLE;
>   	else
>   		rc6->ctl_enable =
> @@ -569,7 +569,7 @@ static void __intel_rc6_disable(struct intel_rc6 *rc6)
>   	struct intel_gt *gt = rc6_to_gt(rc6);
>   
>   	/* Take control of RC6 back from GuC */
> -	intel_guc_rc_disable(&gt->uc.guc);
> +	intel_guc_rc_disable(gt_to_guc(gt));
>   
>   	intel_uncore_forcewake_get(uncore, FORCEWAKE_ALL);
>   	if (GRAPHICS_VER(i915) >= 9)
> diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c
> index 4feef874e6d6..9c6812257ac2 100644
> --- a/drivers/gpu/drm/i915/gt/intel_rps.c
> +++ b/drivers/gpu/drm/i915/gt/intel_rps.c
> @@ -52,7 +52,7 @@ static struct intel_guc_slpc *rps_to_slpc(struct intel_rps *rps)
>   {
>   	struct intel_gt *gt = rps_to_gt(rps);
>   
> -	return &gt->uc.guc.slpc;
> +	return &gt_to_guc(gt)->slpc;
>   }
>   
>   static bool rps_uses_slpc(struct intel_rps *rps)
> diff --git a/drivers/gpu/drm/i915/gt/intel_tlb.c b/drivers/gpu/drm/i915/gt/intel_tlb.c
> index 4bb13d1890e3..756e9ebbc725 100644
> --- a/drivers/gpu/drm/i915/gt/intel_tlb.c
> +++ b/drivers/gpu/drm/i915/gt/intel_tlb.c
> @@ -132,7 +132,7 @@ void intel_gt_invalidate_tlb_full(struct intel_gt *gt, u32 seqno)
>   		return;
>   
>   	with_intel_gt_pm_if_awake(gt, wakeref) {
> -		struct intel_guc *guc = &gt->uc.guc;
> +		struct intel_guc *guc = gt_to_guc(gt);
>   
>   		mutex_lock(&gt->tlb.invalidate_lock);
>   		if (tlb_seqno_passed(gt, seqno))
> diff --git a/drivers/gpu/drm/i915/gt/selftest_slpc.c b/drivers/gpu/drm/i915/gt/selftest_slpc.c
> index 302d0540295d..4ecc4ae74a54 100644
> --- a/drivers/gpu/drm/i915/gt/selftest_slpc.c
> +++ b/drivers/gpu/drm/i915/gt/selftest_slpc.c
> @@ -53,7 +53,7 @@ static int slpc_set_max_freq(struct intel_guc_slpc *slpc, u32 freq)
>   static int slpc_set_freq(struct intel_gt *gt, u32 freq)
>   {
>   	int err;
> -	struct intel_guc_slpc *slpc = &gt->uc.guc.slpc;
> +	struct intel_guc_slpc *slpc = &gt_to_guc(gt)->slpc;
>   
>   	err = slpc_set_max_freq(slpc, freq);
>   	if (err) {
> @@ -182,7 +182,7 @@ static int vary_min_freq(struct intel_guc_slpc *slpc, struct intel_rps *rps,
>   
>   static int slpc_power(struct intel_gt *gt, struct intel_engine_cs *engine)
>   {
> -	struct intel_guc_slpc *slpc = &gt->uc.guc.slpc;
> +	struct intel_guc_slpc *slpc = &gt_to_guc(gt)->slpc;
>   	struct {
>   		u64 power;
>   		int freq;
> @@ -262,7 +262,7 @@ static int max_granted_freq(struct intel_guc_slpc *slpc, struct intel_rps *rps,
>   
>   static int run_test(struct intel_gt *gt, int test_type)
>   {
> -	struct intel_guc_slpc *slpc = &gt->uc.guc.slpc;
> +	struct intel_guc_slpc *slpc = &gt_to_guc(gt)->slpc;
>   	struct intel_rps *rps = &gt->rps;
>   	struct intel_engine_cs *engine;
>   	enum intel_engine_id id;