Re: [PATCH] drm/i915/uapi: fix typos/spellos and punctuation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Hi Randy,

On 13/12/2023 04:40, Randy Dunlap wrote:
Use "its" for possessive form instead of "it's".
Hyphenate multi-word adjectives.
Correct some spelling.
End one line of code with ';' instead of ','. The before and after
   object files are identical.

Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
Cc: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
Cc: Rodrigo Vivi <rodrigo.vivi@xxxxxxxxx>
Cc: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxxxxxxxx>
Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
---
  include/uapi/drm/i915_drm.h |   12 ++++++------
  1 file changed, 6 insertions(+), 6 deletions(-)

diff -- a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h
--- a/include/uapi/drm/i915_drm.h
+++ b/include/uapi/drm/i915_drm.h
@@ -693,7 +693,7 @@ typedef struct drm_i915_irq_wait {
  #define I915_PARAM_HAS_EXEC_FENCE	 44
/* Query whether DRM_I915_GEM_EXECBUFFER2 supports the ability to capture
- * user specified bufffers for post-mortem debugging of GPU hangs. See
+ * user-specified buffers for post-mortem debugging of GPU hangs. See
   * EXEC_OBJECT_CAPTURE.
   */
  #define I915_PARAM_HAS_EXEC_CAPTURE	 45
@@ -1606,7 +1606,7 @@ struct drm_i915_gem_busy {
  	 * is accurate.
  	 *
  	 * The returned dword is split into two fields to indicate both
-	 * the engine classess on which the object is being read, and the
+	 * the engine classes on which the object is being read, and the
  	 * engine class on which it is currently being written (if any).
  	 *
  	 * The low word (bits 0:15) indicate if the object is being written
@@ -1815,7 +1815,7 @@ struct drm_i915_gem_madvise {
  	__u32 handle;
/* Advice: either the buffer will be needed again in the near future,
-	 *         or wont be and could be discarded under memory pressure.
+	 *         or won't be and could be discarded under memory pressure.
  	 */
  	__u32 madv;
@@ -3246,7 +3246,7 @@ struct drm_i915_query_topology_info {
   * 	// enough to hold our array of engines. The kernel will fill out the
   * 	// item.length for us, which is the number of bytes we need.
   * 	//
- * 	// Alternatively a large buffer can be allocated straight away enabling
+ *	// Alternatively a large buffer can be allocated straightaway enabling
   * 	// querying in one pass, in which case item.length should contain the
   * 	// length of the provided buffer.
   * 	err = ioctl(fd, DRM_IOCTL_I915_QUERY, &query);
@@ -3256,7 +3256,7 @@ struct drm_i915_query_topology_info {
   * 	// Now that we allocated the required number of bytes, we call the ioctl
   * 	// again, this time with the data_ptr pointing to our newly allocated
   * 	// blob, which the kernel can then populate with info on all engines.
- * 	item.data_ptr = (uintptr_t)&info,
+ *	item.data_ptr = (uintptr_t)&info;
   *
   * 	err = ioctl(fd, DRM_IOCTL_I915_QUERY, &query);
   * 	if (err) ...
@@ -3286,7 +3286,7 @@ struct drm_i915_query_topology_info {
  /**
   * struct drm_i915_engine_info
   *
- * Describes one engine and it's capabilities as known to the driver.
+ * Describes one engine and its capabilities as known to the driver.
   */
  struct drm_i915_engine_info {
  	/** @engine: Engine class and instance. */

Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@xxxxxxxxx>

Thanks for the clean up! Will merge it as soon as CI gives green light (yes I know its only comments :).

Regards,

Tvrtko



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux