Reviewed-by: Jacek Lawrynowicz <jacek.lawrynowicz@xxxxxxxxxxxxxxx>
On 08.12.2023 17:31, Jeffrey Hugo wrote:
> From: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@xxxxxxxxxxx>
>
> Do not modify the size of dmabuf as it is immutable.
>
> Fixes: ff13be830333 ("accel/qaic: Add datapath")
> Signed-off-by: Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@xxxxxxxxxxx>
> Reviewed-by: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>
> Signed-off-by: Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx>
> ---
> drivers/accel/qaic/qaic_data.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/accel/qaic/qaic_data.c b/drivers/accel/qaic/qaic_data.c
> index 4a8e43a7a6a4..d42f002bc0cf 100644
> --- a/drivers/accel/qaic/qaic_data.c
> +++ b/drivers/accel/qaic/qaic_data.c
> @@ -777,7 +777,6 @@ struct drm_gem_object *qaic_gem_prime_import(struct drm_device *dev, struct dma_
> struct dma_buf_attachment *attach;
> struct drm_gem_object *obj;
> struct qaic_bo *bo;
> - size_t size;
> int ret;
>
> bo = qaic_alloc_init_bo();
> @@ -795,13 +794,12 @@ struct drm_gem_object *qaic_gem_prime_import(struct drm_device *dev, struct dma_
> goto attach_fail;
> }
>
> - size = PAGE_ALIGN(attach->dmabuf->size);
> - if (size == 0) {
> + if (!attach->dmabuf->size) {
> ret = -EINVAL;
> goto size_align_fail;
> }
>
> - drm_gem_private_object_init(dev, obj, size);
> + drm_gem_private_object_init(dev, obj, attach->dmabuf->size);
> /*
> * skipping dma_buf_map_attachment() as we do not know the direction
> * just yet. Once the direction is known in the subsequent IOCTL to
