On 11.12.2023 10:46, Dmitry Baryshkov wrote: > On Mon, 11 Dec 2023 at 11:33, Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote: >> >> On 10.12.2023 00:21, Dmitry Baryshkov wrote: >>> Expand Combo USB+DP QMP PHY device node with the OF ports required to >>> support USB-C / DisplayPort switching. >>> >>> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> >>> --- >>> arch/arm64/boot/dts/qcom/sm8150.dtsi | 23 +++++++++++++++++++++++ >>> 1 file changed, 23 insertions(+) >>> >>> diff --git a/arch/arm64/boot/dts/qcom/sm8150.dtsi b/arch/arm64/boot/dts/qcom/sm8150.dtsi >>> index ea7c92c0e405..38423a9f8408 100644 >>> --- a/arch/arm64/boot/dts/qcom/sm8150.dtsi >>> +++ b/arch/arm64/boot/dts/qcom/sm8150.dtsi >>> @@ -3447,6 +3447,29 @@ usb_1_qmpphy: phy@88e8000 { >>> #phy-cells = <1>; >>> >>> status = "disabled"; >>> + >>> + ports { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + >>> + port@0 { >>> + reg = <0>; >>> + usb_1_qmpphy_out: endpoint {}; >> style 1 >>> + }; >>> + >>> + port@1 { >>> + reg = <1>; >>> + >>> + usb_1_qmpphy_usb_ss_in: endpoint { >>> + }; >> style 2 >>> + }; >>> + >>> + port@2 { >>> + reg = <2>; >>> + >>> + usb_1_qmpphy_dp_in: endpoint {}; >> style 3 >> >> :( > > Which one should I stick to? style 2 seems to be used in 8650 Konrad