On 2023/12/7 17:02, Andy Yan wrote: > > > > > Hi Keith: > > > > > > > > > > > > At 2023-12-06 22:11:33, "Keith Zhao" <keith.zhao@xxxxxxxxxxxxxxxx> wrote: >> >> >>On 2023/12/6 20:56, Maxime Ripard wrote: >>> On Wed, Dec 06, 2023 at 08:02:55PM +0800, Keith Zhao wrote: >>>> >> +static const struct of_device_id starfive_hdmi_dt_ids[] = { >>>> >> + { .compatible = "starfive,jh7110-inno-hdmi",}, >>>> > >>>> > So it's inno hdmi, just like Rockchip then? >>>> > >>>> > This should be a common driver. >>>> >>>> Rockchip has a inno hdmi IP. and Starfive has a inno hdmi IP. >>>> but the harewawre difference of them is big , it is not easy to use the common driver >>>> maybe i need the inno hdmi version here to make a distinction >>> >>> I just had a look at the rockchip header file: all the registers but the >>> STARFIVE_* ones are identical. >>> >>> There's no need to have two identical drivers then, please use the >>> rockchip driver instead. >>> >>> Maxime >> >>ok, have a simple test , edid can get . i will continue > > Maybe you can take drivers/gpu/drm/bridge/synopsys/dw-hdmi as a reference, this > is also a hdmi ip used by rockchip/meson/sunxi/jz/imx。 > We finally make it share one driver。 >> hi Andy: dw_hdmi seems a good choice , it can handle inno hdmi hardware by define its dw_hdmi_plat_data. does it means i can write own driver files such as(dw_hdmi-starfive.c) based on dw_hdmi instead of add plat_data in inno_hdmi.c Thanks for pointing this out!!! >> >>_______________________________________________ >>linux-riscv mailing list >>linux-riscv@xxxxxxxxxxxxxxxxxxx >>http://lists.infradead.org/mailman/listinfo/linux-riscv