On Thu, Dec 07, 2023 at 11:48:56AM +0800, Shengyang Chen wrote: > Hi, Conor > > thanks for comment > > On 2023/12/6 23:40, Conor Dooley wrote: > > On Wed, Dec 06, 2023 at 05:43:48PM +0800, Shengyang Chen wrote: > >> Hi, Conor > >> > >> On 2023/11/24 20:31, Conor Dooley wrote: > >> > On Fri, Nov 24, 2023 at 06:44:50PM +0800, Shengyang Chen wrote: > >> >> The waveshare 7inch touchscreen panel is a kind of raspberrypi pi > >> >> panel > >> > > >> > Can you be more specific about what "is a kind of rpi panel" means? > >> > Are they using identical chips as controllers or something like that? > >> > > >> > >> Wareshare panel has same i2c slave address and registers address with > >> the original raspberry pi panel. They both use Atmel firmware and they > >> got same reg id. It can be operated by using the driver of raspberry pi driver > >> after some change of the code. So I suppose it may be a kind of raspberry pi panel > >> and discribe it in this way. It's my own judgement. Sorry about that. > >> Maybe just like Dave said, It cloned the behaviour of the raspberri pi panel. > >> I will change the discribtion in next version to not make other confused. > >> > >> By the way, we will try Stefan's method before next version. > >> The method we used in this patch may be abandoned if Stefan's method is verified in our platform. > >> At that time yaml may also be changed to fit new method. > > > > I don't know what Stefan's approach is, but I do not think that a > > bindings patch should be dropped. The waveshare might be a clone, but it > > is a distinct device. If the same driver can control both, then the > > compatible setups that should be permitted are: > > compatible = "raspberrypi,7inch-touchscreen-panel"; > > and > > compatible = "waveshare,7inch-touchscreen-panel", "raspberrypi,7inch-touchscreen-panel"; > If we use Stenfan's method, we can reuse the code of panel-simple.c > we may submit our patch to > /Documentation/devicetree/bindings/display/panel/panel-simple.yaml > /drivers/gpu/drm/panel/panel-simple.c > as a new panel porting. That may less confuse. As long as you provide a specific compatible, and not re-use the rpi one, that's fine. It just sounded like you were intending to reuse that here, but from this message it seems like I misunderstood. Thanks, Conor.
Attachment:
signature.asc
Description: PGP signature
