Re: [PATCH v6 06/10] drm: ci: mediatek: Set IGT_FORCE_DRIVER for mt8173

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thanks for your patch.

On 29/11/2023 09:18, Vignesh Raman wrote:
Expected driver for mt8173 is "mediatek" and for mt8183
it is "panfrost". Set IGT_FORCE_DRIVER to 'mediatek' as
the expected driver for mt8173.

Signed-off-by: Vignesh Raman <vignesh.raman@xxxxxxxxxxxxx>
---

v5:
   - Added a new patch in the series to set IGT_FORCE_DRIVER to 'mediatek' for mt8173

v6:
   - Use GPU_VERSION instead of CI_JOB_NAME to check if it is mt8173

---
  drivers/gpu/drm/ci/igt_runner.sh | 4 ++++
  1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/ci/igt_runner.sh b/drivers/gpu/drm/ci/igt_runner.sh
index c6cf963592c5..70a0f84021a1 100755
--- a/drivers/gpu/drm/ci/igt_runner.sh
+++ b/drivers/gpu/drm/ci/igt_runner.sh
@@ -30,6 +30,10 @@ case "$DRIVER_NAME" in
          ;;
  esac
+if [ "$GPU_VERSION" = "mt8173" ]; then
+    export IGT_FORCE_DRIVER=${DRIVER_NAME}
+fi

Just a nit, could you add this in the first case statement? Just to avoid confusing about double assignment? -> but feel free to ignore this comment.

With or without this:

Acked-by: Helen Koike <helen.koike@xxxxxxxxxxxxx>

Thanks
Helen

+
  if [ -e "/install/xfails/$DRIVER_NAME-$GPU_VERSION-skips.txt" ]; then
      IGT_SKIPS="--skips /install/xfails/$DRIVER_NAME-$GPU_VERSION-skips.txt"
  fi



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux