On Mon, Dec 4, 2023 at 5:39 AM Zhipeng Lu <alexious@xxxxxxxxxx> wrote: > > The rdev->pm.dpm.ps allocated by kcalloc should be freed in every > following error-handling path. However, in the error-handling of > rdev->pm.power_state[i].clock_info the rdev->pm.dpm.ps is not freed, > resulting in a memleak in this function. > > Fixes: 80ea2c129c76 ("drm/radeon/kms: add dpm support for sumo asics (v2)") > Signed-off-by: Zhipeng Lu <alexious@xxxxxxxxxx> Applied. Thanks! > --- > > Changelog: > > v2: Adding {} to make if statement correct. > --- > drivers/gpu/drm/radeon/sumo_dpm.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/sumo_dpm.c b/drivers/gpu/drm/radeon/sumo_dpm.c > index f74f381af05f..d49c145db437 100644 > --- a/drivers/gpu/drm/radeon/sumo_dpm.c > +++ b/drivers/gpu/drm/radeon/sumo_dpm.c > @@ -1493,8 +1493,10 @@ static int sumo_parse_power_table(struct radeon_device *rdev) > non_clock_array_index = power_state->v2.nonClockInfoIndex; > non_clock_info = (struct _ATOM_PPLIB_NONCLOCK_INFO *) > &non_clock_info_array->nonClockInfo[non_clock_array_index]; > - if (!rdev->pm.power_state[i].clock_info) > + if (!rdev->pm.power_state[i].clock_info) { > + kfree(rdev->pm.dpm.ps); > return -EINVAL; > + } > ps = kzalloc(sizeof(struct sumo_ps), GFP_KERNEL); > if (ps == NULL) { > kfree(rdev->pm.dpm.ps); > -- > 2.34.1 >