On Thu, 30 Nov 2023, Khaled Almahallawy <khaled.almahallawy@xxxxxxxxx> wrote: > DP2.1 Specs added new DPCDs definitions for square pattern configs[1] > These new definitions are used for UHBR Source Transmitter > Equalizations tests[2]. Add the 3 new values for square pattern. > > v2: rebase > > [1]: DP2.1 Specs - 2.12.3.6.5 Square Pattern > [2]: DP2.1 PHY CTS specs - 4.3 UHBR Source Transmitter Equalization > > Cc: Jani Nikula <jani.nikula@xxxxxxxxx> > Cc: Imre Deak <imre.deak@xxxxxxxxx> > Cc: Lee Shawn C <shawn.c.lee@xxxxxxxxx> > Signed-off-by: Khaled Almahallawy <khaled.almahallawy@xxxxxxxxx> Thanks for the patch, pushed to drm-misc-next. BR, Jani. > --- > include/drm/display/drm_dp.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/drm/display/drm_dp.h b/include/drm/display/drm_dp.h > index 83d2039c018b..3731828825bd 100644 > --- a/include/drm/display/drm_dp.h > +++ b/include/drm/display/drm_dp.h > @@ -651,6 +651,9 @@ > # define DP_LINK_QUAL_PATTERN_PRSBS31 0x38 > # define DP_LINK_QUAL_PATTERN_CUSTOM 0x40 > # define DP_LINK_QUAL_PATTERN_SQUARE 0x48 > +# define DP_LINK_QUAL_PATTERN_SQUARE_PRESHOOT_DISABLED 0x49 > +# define DP_LINK_QUAL_PATTERN_SQUARE_DEEMPHASIS_DISABLED 0x4a > +# define DP_LINK_QUAL_PATTERN_SQUARE_PRESHOOT_DEEMPHASIS_DISABLED 0x4b > > #define DP_TRAINING_LANE0_1_SET2 0x10f > #define DP_TRAINING_LANE2_3_SET2 0x110 -- Jani Nikula, Intel