Thomas Zimmermann <tzimmermann@xxxxxxx> writes: > Use the screen_info instance from the device instead of dereferencing > the global screen_info state. Decouples the driver from per-architecture > code. Duplicated the screen_info data, so that efifb can modify it at > will. > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > --- [...] > + si = dev_get_platdata(&dev->dev); > + if (!si) I would add a comment that this platform data is set when the device is registered by sysfb. > + return -ENODEV; > + si = devm_kmemdup(&dev->dev, si, sizeof(*si), GFP_KERNEL); > + if (!si) > + return -ENOMEM; > + Why a copy? In any case maybe the global screen_info should be duplicated when is set as the device platform data in sysfb_init() ? I agree with the direction of the patch though, so whatever you decide: Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
