Re: [PATCH] [drm/meson] meson_plane: Add error handling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

Thanks for your patch!

On 29/11/2023 10:21, Haoran Liu wrote:
This patch adds robust error handling to the meson_plane_create
function in drivers/gpu/drm/meson/meson_plane.c. The function
previously lacked proper handling for potential failure scenarios
of the drm_universal_plane_init call.

Signed-off-by: Haoran Liu <liuhaoran14@xxxxxxx>
---
  drivers/gpu/drm/meson/meson_plane.c | 7 ++++++-
  1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/meson/meson_plane.c b/drivers/gpu/drm/meson/meson_plane.c
index 815dfe30492b..67b36398f146 100644
--- a/drivers/gpu/drm/meson/meson_plane.c
+++ b/drivers/gpu/drm/meson/meson_plane.c
@@ -534,6 +534,7 @@ int meson_plane_create(struct meson_drm *priv)
  	struct meson_plane *meson_plane;
  	struct drm_plane *plane;
  	const uint64_t *format_modifiers = format_modifiers_default;
+	int ret;
meson_plane = devm_kzalloc(priv->drm->dev, sizeof(*meson_plane),
  				   GFP_KERNEL);
@@ -548,12 +549,16 @@ int meson_plane_create(struct meson_drm *priv)
  	else if (meson_vpu_is_compatible(priv, VPU_COMPATIBLE_G12A))
  		format_modifiers = format_modifiers_afbc_g12a;
- drm_universal_plane_init(priv->drm, plane, 0xFF,
+	ret = drm_universal_plane_init(priv->drm, plane, 0xFF,
  				 &meson_plane_funcs,
  				 supported_drm_formats,
  				 ARRAY_SIZE(supported_drm_formats),
  				 format_modifiers,
  				 DRM_PLANE_TYPE_PRIMARY, "meson_primary_plane");

Could you re-align those lines aswell ?

+	if (ret) {
+		devm_kfree(priv->drm->dev, meson_plane);
+		return ret;
+	}
drm_plane_helper_add(plane, &meson_plane_helper_funcs);

Thanks,
Neil



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux