Hi, On Thu, Nov 23, 2023 at 9:54 AM Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > This aligns the function's parameters to regmap_{read,write} and > simplifies the next change that takes pwm driver data out of struct > ti_sn65dsi86. > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > drivers/gpu/drm/bridge/ti-sn65dsi86.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) I'm on the fence for this one. It almost feels like if this takes a "regmap" as the first field then it should be part of the regmap API. Adding a concept like this to the regmap API might be interesting if there were more than one user, but that's a pretty big yak to shave. I'd tend to agree with your statement in the cover letter that this patch really makes more sense if we were to take patch #3, and (as per my response there) I'm not convinced. That being said, similar to patch #3 if everything else thinks this is great then I won't stand in the way. -Doug