On Tue, Nov 28, 2023 at 11:28 AM Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> wrote: > > The function device_is_dependent() is only called by the driver core > internally and should not, at this time, be called by anyone else > outside of it, so mark it as static so as not to give driver authors the > wrong idea. > > Cc: "Rafael J. Wysocki" <rafael@xxxxxxxxxx> > Cc: Saravana Kannan <saravanak@xxxxxxxxxx> > Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> Acked-by: "Rafael J. Wysocki" <rafael@xxxxxxxxxx> > --- > drivers/base/core.c | 2 +- > include/linux/device.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/base/core.c b/drivers/base/core.c > index dafdb9970901..6dcc26eec096 100644 > --- a/drivers/base/core.c > +++ b/drivers/base/core.c > @@ -298,7 +298,7 @@ static inline bool device_link_flag_is_sync_state_only(u32 flags) > * Check if @target depends on @dev or any device dependent on it (its child or > * its consumer etc). Return 1 if that is the case or 0 otherwise. > */ > -int device_is_dependent(struct device *dev, void *target) > +static int device_is_dependent(struct device *dev, void *target) > { > struct device_link *link; > int ret; > diff --git a/include/linux/device.h b/include/linux/device.h > index c11d60cabaab..6a4ee40af3df 100644 > --- a/include/linux/device.h > +++ b/include/linux/device.h > @@ -1071,7 +1071,6 @@ int device_rename(struct device *dev, const char *new_name); > int device_move(struct device *dev, struct device *new_parent, > enum dpm_order dpm_order); > int device_change_owner(struct device *dev, kuid_t kuid, kgid_t kgid); > -int device_is_dependent(struct device *dev, void *target); > > static inline bool device_supports_offline(struct device *dev) > { > -- > 2.43.0 >