On Fri, 13 Oct 2023 11:25:15 +0300, Dan Carpenter wrote: > This NULL check was required when it was added, but we shuffled the code > around and now it's not. The inconsistent NULL checking triggers a > Smatch warning: > > drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c:847 mdp5_init() warn: > variable dereferenced before check 'mdp5_kms' (see line 782) > > [...] Applied, thanks! [1/1] drm/msm: remove unnecessary NULL check https://gitlab.freedesktop.org/drm/msm/-/commit/56466f653cb5 Best regards, -- Abhinav Kumar <quic_abhinavk@xxxxxxxxxxx>