Re: [Bug 218168] New: amdgpu: kfd_topology.c warning: the frame size of 1408 bytes is larger than 1024 bytes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



There are two patches that didn't make it into Linux 6.6 that reduce the stack size in kfd_topology_add_device. Can you check if those fix the problem?

commit aa5a9b2ccda2fa834fddb4bd30a2ab831598f551
Author: Alex Deucher <alexander.deucher@xxxxxxx>
Date:   Tue Sep 26 12:00:23 2023 -0400

    drm/amdkfd: drop struct kfd_cu_info
I think this was an abstraction back from when
    kfd supported both radeon and amdgpu.  Since we just
    support amdgpu now, there is no more need for this and
    we can use the amdgpu structures directly.
This also avoids having the kfd_cu_info structures on
    the stack when inlining which can blow up the stack.
Cc: Arnd Bergmann <arnd@xxxxxxxxxx>
    Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
    Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>
    Acked-by: Christian König <christian.koenig@xxxxxxx>
    Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>

commit 1f3b515578a1d73926993629a06a7f3b60535b59
Author: Alex Deucher <alexander.deucher@xxxxxxx>
Date:   Thu Sep 21 10:32:09 2023 -0400

    drm/amdkfd: reduce stack size in kfd_topology_add_device()
kfd_topology.c:2082:1: warning: the frame size of 1440 bytes is larger than 1024 bytes Link: https://gitlab.freedesktop.org/drm/amd/-/issues/2866
    Cc: Arnd Bergmann <arnd@xxxxxxxxxx>
    Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
    Acked-by: Christian König <christian.koenig@xxxxxxx>
    Reviewed-by: Felix Kuehling <Felix.Kuehling@xxxxxxx>
    Signed-off-by: Alex Deucher <alexander.deucher@xxxxxxx>

Regards,
  Felix


On 2023-11-20 10:36, Hamza Mahfooz wrote:
+ amd-gfx
+ Felix

On 11/20/23 10:16, bugzilla-daemon@xxxxxxxxxx wrote:
https://bugzilla.kernel.org/show_bug.cgi?id=218168

             Bug ID: 218168
            Summary: amdgpu: kfd_topology.c warning: the frame size of 1408
                     bytes is larger than 1024 bytes
            Product: Drivers
            Version: 2.5
           Hardware: All
                 OS: Linux
             Status: NEW
           Severity: normal
           Priority: P3
          Component: Video(DRI - non Intel)
           Assignee: drivers_video-dri@xxxxxxxxxxxxxxxxxxxx
           Reporter: bluesun654@xxxxxxxxx
         Regression: No

Trying to compile Linux 6.6.2 with GCC 13.2.1 and CONFIG_WERROR=y:

[...]
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c: In function
'kfd_topology_add_device':
drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_topology.c:2082:1: error: the frame size of 1408 bytes is larger than 1024 bytes [-Werror=frame-larger-than=]
  2082 | }
       | ^
cc1: all warnings being treated as errors
[...]




[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux