Hello Alexander,
On Fri, Nov 17, 2023 at 08:33:16AM +0100, Alexander Stein wrote:
> Use dev_err_probe to simplify error paths. Also Let dev_err_probe handle
s/Let/let/
> the -EPROBE_DEFER case and also add an entry to
I'd s/also //
> /sys/kernel/debug/devices_deferred when deferred.
>
> Signed-off-by: Alexander Stein <alexander.stein@xxxxxxxxxxxxxxx>
> [...]
> @@ -568,7 +570,7 @@ static int pwm_backlight_probe(struct platform_device *pdev)
> ret = pwm_backlight_brightness_default(&pdev->dev, data,
> state.period);
> if (ret < 0) {
> - dev_err(&pdev->dev,
> + dev_err_probe(&pdev->dev, ret,
> "failed to setup default brightness table\n");
Missing realign of the continuation line.
> goto err_alloc;
> }
Otherwise LGTM
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
