On 16/11/2023 17:28, Rob Herring wrote: > On Mon, Nov 13, 2023 at 01:51:30PM +0000, Conor Dooley wrote: >> On Sun, Nov 12, 2023 at 07:44:01PM +0100, Krzysztof Kozlowski wrote: >>> When number of clock varies between variants, the Devicetree bindings >>> coding convention expects to have widest constraints in top-level >>> definition of the properties and narrow them in allOf:if:then block. >>> >>> This is more readable and sometimes allows to spot some errors in the >>> bindings. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> >> >> Åcked-by: Conor Dooley <conor.dooley@xxxxxxxxxxxxx> > > ^ > > Not an 'A'. I only caught this because I go thru everything > Acked/Reviewed-by first and this one was missed. And in Norwegian it is pronounced as "o", so this would be ocked-by :) Best regards, Krzysztof