Thomas Zimmermann <tzimmermann@xxxxxxx> writes: > Initialize the instance of struct fb_ops with fbdev initializer > macros for framebuffers in DMA-able virtual address space. Set the > read/write, draw and mmap callbacks to the correct implementation > and avoid implicit defaults. Also select the necessary helpers in > Kconfig. > > The driver uses a mixture of DMA helpers and deferred I/O. That > probably needs fixing by a driver maintainer. > > Fbdev drivers sometimes rely on the callbacks being NULL for a > default I/O-memory-based implementation to be invoked; hence > requiring the I/O helpers to be built in any case. Setting all > callbacks in all drivers explicitly will allow to make the I/O > helpers optional. This benefits systems that do not use these > functions. > > Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > --- Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
