Thomas Zimmermann <tzimmermann@xxxxxxx> writes:
> Only initialize mmap and draw helpers with macros; leave read/write
> callbacks to driver implementations. Fixes the following warnings:
>
> CC [M] drivers/video/fbdev/sm712fb.o
> sm712fb.c:1355:25: warning: initialized field overwritten [-Woverride-init]
> 1355 | .fb_fillrect = cfb_fillrect,
> | ^~~~~~~~~~~~
> sm712fb.c:1355:25: note: (near initialization for 'smtcfb_ops.fb_fillrect')
> sm712fb.c:1356:25: warning: initialized field overwritten [-Woverride-init]
> 1356 | .fb_imageblit = cfb_imageblit,
> | ^~~~~~~~~~~~~
> sm712fb.c:1356:25: note: (near initialization for 'smtcfb_ops.fb_imageblit')
> sm712fb.c:1357:25: warning: initialized field overwritten [-Woverride-init]
> 1357 | .fb_copyarea = cfb_copyarea,
> | ^~~~~~~~~~~~
> sm712fb.c:1357:25: note: (near initialization for 'smtcfb_ops.fb_copyarea')
> sm712fb.c:1358:25: warning: initialized field overwritten [-Woverride-init]
> 1358 | .fb_read = smtcfb_read,
> | ^~~~~~~~~~~
> sm712fb.c:1358:25: note: (near initialization for 'smtcfb_ops.fb_read')
> sm712fb.c:1359:25: warning: initialized field overwritten [-Woverride-init]
> 1359 | .fb_write = smtcfb_write,
> | ^~~~~~~~~~~~
> sm712fb.c:1359:25: note: (near initialization for 'smtcfb_ops.fb_write')
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Fixes: 586132cf1d38 ("fbdev/sm712fb: Initialize fb_ops to fbdev I/O-memory helpers")
> Cc: Thomas Zimmermann <tzimmermann@xxxxxxx>
> Cc: Javier Martinez Canillas <javierm@xxxxxxxxxx>
> Cc: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx>
> Cc: Teddy Wang <teddy.wang@xxxxxxxxxxxxxxxxx>
> Cc: Sam Ravnborg <sam@xxxxxxxxxxxx>
> Cc: Helge Deller <deller@xxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: linux-fbdev@xxxxxxxxxxxxxxx
> ---
> drivers/video/fbdev/sm712fb.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
Reviewed-by: Javier Martinez Canillas <javierm@xxxxxxxxxx>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
