On Fri, Nov 10, 2023 at 3:20 PM Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > On Sun, 5 Nov 2023 18:44:03 -0800 Mina Almasry wrote: > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h > > @@ -52,6 +52,8 @@ > > #include <net/net_trackers.h> > > #include <net/net_debug.h> > > #include <net/dropreason-core.h> > > +#include <linux/xarray.h> > > +#include <linux/refcount.h> > > > > struct netpoll_info; > > struct device; > > @@ -808,6 +810,84 @@ bool rps_may_expire_flow(struct net_device *dev, u16 rxq_index, u32 flow_id, > > #endif > > #endif /* CONFIG_RPS */ > > > > +struct netdev_dmabuf_binding { > > Similar nitpick to the skbuff.h comment. Take this somewhere else, > please, it doesn't need to be included in netdevice.h > > > + struct netdev_dmabuf_binding *rbinding; > > the 'r' in rbinding stands for rx? 🤔️ > reverse binding. As in usually it's netdev->binding, but the reverse map holds the bindings themselves so we can unbind them from the netdev. -- Thanks, Mina