> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Sent: Wednesday, November 8, 2023 4:14 PM > Exynos5433 reuses several devices from older designs, thus historically we > kept the old (block's) compatible only. This works fine and there is no bug > here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to Exynos5433 in front of all old-SoC-like > compatibles. This will also help reviews of new code using existing DTS as > template. No functional impact on Linux drivers behavior. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > --- Reviewed-by: Alim Akhtar <alim.akhtar@xxxxxxxxxxx> > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 60 ++++++++++++++-------- > 1 file changed, 39 insertions(+), 21 deletions(-) > (...)
