Re: [PATCH 4/5] accel/ivpu: Use dedicated work for job timeout detection

Jeffrey Hugo <quic_jhugo@xxxxxxxxxxx> · Thu, 9 Nov 2023 21:35:53 -0700

On 11/7/2023 5:35 AM, Jacek Lawrynowicz wrote:
From: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>

Change to use work for timeout detection. Needed for thread_irq
conversion.

Signed-off-by: Stanislaw Gruszka <stanislaw.gruszka@xxxxxxxxxxxxxxx>

Missing SOB.

  void ivpu_pm_cancel_recovery(struct ivpu_device *vdev)
  {
+	drm_WARN_ON(&vdev->drm, delayed_work_pending(&vdev->pm->job_timeout_work));

This seems odd.  Looks like this function is only called from the 
dev_fini.  It's a non-fatal error to tear down the device (hotplug? 
fatal error?) if a job is pending?

-Jeff