Re: [PATCH 01/22] fb: amifb: Stop using platform_driver_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/8/23 22:34, Geert Uytterhoeven wrote:
Hi Helge,

On Wed, Nov 8, 2023 at 10:32 PM Helge Deller <deller@xxxxxx> wrote:
On 11/8/23 22:06, Geert Uytterhoeven wrote:
On Tue, Nov 7, 2023 at 10:20 AM Uwe Kleine-König
<u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
On today's platforms the benefit of platform_driver_probe() isn't that
relevant any more. It allows to drop some code after booting (or module
loading) for .probe() and discard the .remove() function completely if
the driver is built-in. This typically saves a few 100k.

Which is a lot on platforms with only a few MiBs of RAM...

True.
Given the warnings below, what is your suggestion?
Better to drop the amifb patch ?

I think so. There is a reason these drivers use platform_driver_probe().

Ok, I've dropped both amifb patches.

Helge





[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux