On Thu, 02 Nov 2023, Jani Nikula <jani.nikula@xxxxxxxxx> wrote: > On Tue, 31 Oct 2023, Jani Nikula <jani.nikula@xxxxxxxxx> wrote: >> v2 of https://patchwork.freedesktop.org/series/123384/ >> >> Jani Nikula (6): >> drm/edid: split out drm_eld.h from drm_edid.h >> drm/eld: replace uint8_t with u8 >> drm/edid: include drm_eld.h only where required >> drm/edid: use a temp variable for sads to drop one level of >> dereferences >> drm/edid: add helpers to get/set struct cea_sad from/to 3-byte sad >> drm/eld: add helpers to modify the SADs of an ELD > > Maxime, Maarten, Thomas - > > I'm moving a bunch of code around here, and would like to get your acks > before merging. I'm planning on merging this via drm-misc-next, it's > just that it only has Intel reviews, and don't want to feel like I'm > sneaking this in. Merged with Maxime's IRC ack, which I forgot to add to the commit messages. *facepalm*. Sorry about that. Thanks Mitul for reviews! BR, Jani. > > Thanks, > Jani. > >> >> Documentation/gpu/drm-kms-helpers.rst | 6 + >> drivers/gpu/drm/Makefile | 1 + >> .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 1 + >> drivers/gpu/drm/drm_edid.c | 43 +++-- >> drivers/gpu/drm/drm_eld.c | 55 ++++++ >> drivers/gpu/drm/drm_internal.h | 6 + >> drivers/gpu/drm/i915/display/intel_audio.c | 1 + >> .../drm/i915/display/intel_crtc_state_dump.c | 1 + >> drivers/gpu/drm/i915/display/intel_sdvo.c | 1 + >> drivers/gpu/drm/nouveau/dispnv50/disp.c | 1 + >> drivers/gpu/drm/radeon/radeon_audio.c | 1 + >> drivers/gpu/drm/tegra/hdmi.c | 1 + >> drivers/gpu/drm/tegra/sor.c | 1 + >> include/drm/drm_edid.h | 148 ---------------- >> include/drm/drm_eld.h | 164 ++++++++++++++++++ >> sound/core/pcm_drm_eld.c | 1 + >> sound/soc/codecs/hdac_hdmi.c | 1 + >> sound/soc/codecs/hdmi-codec.c | 1 + >> sound/x86/intel_hdmi_audio.c | 1 + >> 19 files changed, 275 insertions(+), 160 deletions(-) >> create mode 100644 drivers/gpu/drm/drm_eld.c >> create mode 100644 include/drm/drm_eld.h -- Jani Nikula, Intel