On Mon, 06 Nov 2023, Bagas Sanjaya <bagasdotme@xxxxxxxxx> wrote: > On Sun, Nov 05, 2023 at 09:26:26PM -0800, Randy Dunlap wrote: >> >> >> On 11/5/23 21:15, Bagas Sanjaya wrote: >> > On Sun, Nov 05, 2023 at 04:00:44PM -0500, Hunter Chasens wrote: >> >> diff --git a/drivers/gpu/drm/amd/pm/amdgpu_pm.c b/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> >> index 517b9fb4624c..703fe2542258 100644 >> >> --- a/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> >> +++ b/drivers/gpu/drm/amd/pm/amdgpu_pm.c >> >> @@ -990,11 +990,14 @@ static ssize_t amdgpu_get_pp_features(struct device *dev, >> >> * the power state and the clock information for those levels. If deep sleep is >> >> * applied to a clock, the level will be denoted by a special level 'S:' >> >> * E.g., >> >> - * S: 19Mhz * >> >> - * 0: 615Mhz >> >> - * 1: 800Mhz >> >> - * 2: 888Mhz >> >> - * 3: 1000Mhz >> >> + * >> >> + * :: The literal block marker :: could be added at the end of the preceding paragraph, so it doesn't stand out so much. See [1]. BR, Jani. [1] https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics.html#literal-blocks >> >> + * >> >> + * S: 19Mhz * >> >> + * 0: 615Mhz >> >> + * 1: 800Mhz >> >> + * 2: 888Mhz >> >> + * 3: 1000Mhz >> >> * >> >> * >> >> * To manually adjust these states, first select manual using >> > >> > LGTM, thanks! >> > >> > Fixes: 615585d09b33 ("Documentation/amdgpu: Modify pp_dpm_*clk details") >> > Reviewed-by: Bagas Sanjaya <bagasdotme@xxxxxxxxx> >> > >> >> but can it be done without being so obvious about using Sphinx (or is it ReST?) >> in source files? > > Yes, the comment is included in Documentation/gpu/amdgpu/thermal.rst, so reST > syntax applies there. -- Jani Nikula, Intel
