On Thu, Nov 02, 2023 at 08:40:10AM +0200, Tomi Valkeinen wrote: > On 01/11/2023 15:57, Laurent Pinchart wrote: > > On Wed, Nov 01, 2023 at 11:17:41AM +0200, Tomi Valkeinen wrote: > >> We do a DSS reset in the middle of the dispc_init(). While that happens > >> to work now, we should really make sure that e..g the fclk, which is > >> acquired only later in the function, is enabled when doing a reset. This > >> will be handled in a later patch, but for now, let's move the > >> dispc_softreset() call to the end of dispc_init(), which is a sensible > >> place for it anyway. > >> > >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@xxxxxxxxxxxxxxxx> > > > > Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > > > But do I understand correctly that the device isn't powered up at this > > point ? That seems problematic. > > Indeed. It's fixed later in this series. > > > I'm also not sure why we need to reset the device at probe time. > > That's the usual place to do a reset, to make sure the HW is in a known > state, is it not? Where would you place it? The first time the device is used, or possibly every time it is resumed ? It seems that you're resuming it at probe time for the only reason that you want to then reset it. Resuming it at probe could get entirely skipped. -- Regards, Laurent Pinchart
