Hi Mario, kernel test robot noticed the following build errors: [auto build test ERROR on pci/for-linus] [also build test ERROR on drm-misc/drm-misc-next westeri-thunderbolt/next rafael-pm/linux-next rafael-pm/acpi-bus linus/master rafael-pm/devprop v6.6 next-20231103] [cannot apply to pci/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Mario-Limonciello/drm-nouveau-Switch-from-pci_is_thunderbolt_attached-to-dev_is_removable/20231104-030945 base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git for-linus patch link: https://lore.kernel.org/r/20231103190758.82911-4-mario.limonciello%40amd.com patch subject: [PATCH v2 3/9] PCI: Drop pci_is_thunderbolt_attached() config: loongarch-randconfig-002-20231104 (https://download.01.org/0day-ci/archive/20231104/202311040800.zpVIwNrB-lkp@xxxxxxxxx/config) compiler: loongarch64-linux-gcc (GCC) 13.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231104/202311040800.zpVIwNrB-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202311040800.zpVIwNrB-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c: In function 'nbio_v2_3_enable_aspm': >> drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c:364:21: error: implicit declaration of function 'pci_is_thunderbolt_attached' [-Werror=implicit-function-declaration] 364 | if (pci_is_thunderbolt_attached(adev->pdev)) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors -- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c: In function 'amdgpu_device_ip_early_init': >> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c:2118:14: error: implicit declaration of function 'pci_is_thunderbolt_attached' [-Werror=implicit-function-declaration] 2118 | !pci_is_thunderbolt_attached(to_pci_dev(dev->dev))) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/pci_is_thunderbolt_attached +364 drivers/gpu/drm/amd/amdgpu/nbio_v2_3.c f1213b15976881d Evan Quan 2020-08-18 350 f1213b15976881d Evan Quan 2020-08-18 351 static void nbio_v2_3_enable_aspm(struct amdgpu_device *adev, f1213b15976881d Evan Quan 2020-08-18 352 bool enable) f1213b15976881d Evan Quan 2020-08-18 353 { f1213b15976881d Evan Quan 2020-08-18 354 uint32_t def, data; f1213b15976881d Evan Quan 2020-08-18 355 f1213b15976881d Evan Quan 2020-08-18 356 def = data = RREG32_PCIE(smnPCIE_LC_CNTL); f1213b15976881d Evan Quan 2020-08-18 357 f1213b15976881d Evan Quan 2020-08-18 358 if (enable) { f1213b15976881d Evan Quan 2020-08-18 359 /* Disable ASPM L0s/L1 first */ f1213b15976881d Evan Quan 2020-08-18 360 data &= ~(PCIE_LC_CNTL__LC_L0S_INACTIVITY_MASK | PCIE_LC_CNTL__LC_L1_INACTIVITY_MASK); f1213b15976881d Evan Quan 2020-08-18 361 f1213b15976881d Evan Quan 2020-08-18 362 data |= NAVI10_PCIE__LC_L0S_INACTIVITY_DEFAULT << PCIE_LC_CNTL__LC_L0S_INACTIVITY__SHIFT; f1213b15976881d Evan Quan 2020-08-18 363 f1213b15976881d Evan Quan 2020-08-18 @364 if (pci_is_thunderbolt_attached(adev->pdev)) f1213b15976881d Evan Quan 2020-08-18 365 data |= NAVI10_PCIE__LC_L1_INACTIVITY_TBT_DEFAULT << PCIE_LC_CNTL__LC_L1_INACTIVITY__SHIFT; f1213b15976881d Evan Quan 2020-08-18 366 else f1213b15976881d Evan Quan 2020-08-18 367 data |= NAVI10_PCIE__LC_L1_INACTIVITY_DEFAULT << PCIE_LC_CNTL__LC_L1_INACTIVITY__SHIFT; f1213b15976881d Evan Quan 2020-08-18 368 f1213b15976881d Evan Quan 2020-08-18 369 data &= ~PCIE_LC_CNTL__LC_PMI_TO_L1_DIS_MASK; f1213b15976881d Evan Quan 2020-08-18 370 } else { f1213b15976881d Evan Quan 2020-08-18 371 /* Disbale ASPM L1 */ f1213b15976881d Evan Quan 2020-08-18 372 data &= ~PCIE_LC_CNTL__LC_L1_INACTIVITY_MASK; f1213b15976881d Evan Quan 2020-08-18 373 /* Disable ASPM TxL0s */ f1213b15976881d Evan Quan 2020-08-18 374 data &= ~PCIE_LC_CNTL__LC_L0S_INACTIVITY_MASK; f1213b15976881d Evan Quan 2020-08-18 375 /* Disable ACPI L1 */ f1213b15976881d Evan Quan 2020-08-18 376 data |= PCIE_LC_CNTL__LC_PMI_TO_L1_DIS_MASK; f1213b15976881d Evan Quan 2020-08-18 377 } f1213b15976881d Evan Quan 2020-08-18 378 f1213b15976881d Evan Quan 2020-08-18 379 if (def != data) f1213b15976881d Evan Quan 2020-08-18 380 WREG32_PCIE(smnPCIE_LC_CNTL, data); f1213b15976881d Evan Quan 2020-08-18 381 } f1213b15976881d Evan Quan 2020-08-18 382 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
