Re: [PATCH v3 14/15] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Andy,

kernel test robot noticed the following build errors:

[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-intel/for-linux-next-fixes linus/master v6.6 next-20231103]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/drm-i915-dsi-assume-BXT-gpio-works-for-non-native-GPIO/20231103-064642
base:   git://anongit.freedesktop.org/drm-intel for-linux-next
patch link:    https://lore.kernel.org/r/20231102151228.668842-15-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v3 14/15] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20231104/202311040312.Tf6bTkw0-lkp@xxxxxxxxx/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231104/202311040312.Tf6bTkw0-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311040312.Tf6bTkw0-lkp@xxxxxxxxx/

All errors (new ones prefixed by >>):

>> drivers/gpu/drm/i915/display/intel_dsi_vbt.c:272:4: error: call to undeclared function 'soc_exec_opaque_gpio'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                           soc_exec_opaque_gpio(connector, gpio_index, "INT33FF:03", "Panel SE",
                           ^
   drivers/gpu/drm/i915/display/intel_dsi_vbt.c:275:4: error: call to undeclared function 'soc_exec_opaque_gpio'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                           soc_exec_opaque_gpio(connector, gpio_index, "INT33FF:00", "Panel SW",
                           ^
   drivers/gpu/drm/i915/display/intel_dsi_vbt.c:278:4: error: call to undeclared function 'soc_exec_opaque_gpio'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                           soc_exec_opaque_gpio(connector, gpio_index, "INT33FF:02", "Panel E",
                           ^
   drivers/gpu/drm/i915/display/intel_dsi_vbt.c:281:4: error: call to undeclared function 'soc_exec_opaque_gpio'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                           soc_exec_opaque_gpio(connector, gpio_index, "INT33FF:01", "Panel N",
                           ^
   drivers/gpu/drm/i915/display/intel_dsi_vbt.c:299:3: error: call to undeclared function 'soc_exec_opaque_gpio'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                   soc_exec_opaque_gpio(connector, gpio_index, "INT33FF:01", "Panel N",
                   ^
   5 errors generated.


vim +/soc_exec_opaque_gpio +272 drivers/gpu/drm/i915/display/intel_dsi_vbt.c

   263	
   264	static void chv_gpio_set_value(struct intel_connector *connector,
   265				       u8 gpio_source, u8 gpio_index, bool value)
   266	{
   267		struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
   268	
   269		if (connector->panel.vbt.dsi.seq_version >= 3) {
   270			if (gpio_index >= CHV_GPIO_IDX_START_SE) {
   271				/* XXX: it's unclear whether 255->57 is part of SE. */
 > 272				soc_exec_opaque_gpio(connector, gpio_index, "INT33FF:03", "Panel SE",
   273						     gpio_index - CHV_GPIO_IDX_START_SW, value);
   274			} else if (gpio_index >= CHV_GPIO_IDX_START_SW) {
   275				soc_exec_opaque_gpio(connector, gpio_index, "INT33FF:00", "Panel SW",
   276						     gpio_index - CHV_GPIO_IDX_START_SW, value);
   277			} else if (gpio_index >= CHV_GPIO_IDX_START_E) {
   278				soc_exec_opaque_gpio(connector, gpio_index, "INT33FF:02", "Panel E",
   279						     gpio_index - CHV_GPIO_IDX_START_E, value);
   280			} else {
   281				soc_exec_opaque_gpio(connector, gpio_index, "INT33FF:01", "Panel N",
   282						     gpio_index - CHV_GPIO_IDX_START_N, value);
   283			}
   284		} else {
   285			/* XXX: The spec is unclear about CHV GPIO on seq v2 */
   286			if (gpio_source != 0) {
   287				drm_dbg_kms(&dev_priv->drm,
   288					    "unknown gpio source %u\n", gpio_source);
   289				return;
   290			}
   291	
   292			if (gpio_index >= CHV_GPIO_IDX_START_E) {
   293				drm_dbg_kms(&dev_priv->drm,
   294					    "invalid gpio index %u for GPIO N\n",
   295					    gpio_index);
   296				return;
   297			}
   298	
   299			soc_exec_opaque_gpio(connector, gpio_index, "INT33FF:01", "Panel N",
   300					     gpio_index - CHV_GPIO_IDX_START_N, value);
   301		}
   302	}
   303	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki



[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux