Hello, On Thu, Nov 02, 2023 at 05:56:48PM +0100, Uwe Kleine-König wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is (mostly) ignored > and this typically results in resource leaks. To improve here there is a > quest to make the remove callback return void. In the first step of this > quest all drivers are converted to .remove_new() which already returns > void. > > Trivially convert the etnaviv drm driver from always returning zero in > the remove callback to the void returning variant. > > Reviewed-by: Thomas Zimmermann <tzimmermann@xxxxxxx> > Reviewed-by: Jyri Sarha <jyri.sarha@xxxxxx> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> I failed to pick up the tag Reviewed-by: Christian Gmeiner <cgmeiner@xxxxxxxxxx> that this patch got in v2 at https://lore.kernel.org/dri-devel/CAH9NwWdzVPrZD3Uo04fWXR0Cv=okK+P+njAR81gprCxKqp5icw@xxxxxxxxxxxxxx Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |
Attachment:
signature.asc
Description: PGP signature
