El mar, 24-10-2023 a las 07:05 -0300, Maira Canal escribió: > Hi Iago, > > On 10/24/23 02:57, Iago Toral wrote: > > El lun, 23-10-2023 a las 07:58 -0300, Maíra Canal escribió: > > > Currently, we are only warning the user if the BIN or RENDER jobs > > > don't > > > finish before we unregister V3D. We must wait for all jobs to > > > finish > > > before unregistering. Therefore, warn the user if TFU or CSD jobs > > > are not done by the time the driver is unregistered. > > > > > > Signed-off-by: Maíra Canal <mcanal@xxxxxxxxxx> > > > --- > > > drivers/gpu/drm/v3d/v3d_gem.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/v3d/v3d_gem.c > > > b/drivers/gpu/drm/v3d/v3d_gem.c > > > index 2e94ce788c71..afa7d170d1ff 100644 > > > --- a/drivers/gpu/drm/v3d/v3d_gem.c > > > +++ b/drivers/gpu/drm/v3d/v3d_gem.c > > > @@ -1072,6 +1072,8 @@ v3d_gem_destroy(struct drm_device *dev) > > > */ > > > WARN_ON(v3d->bin_job); > > > WARN_ON(v3d->render_job); > > > + WARN_ON(v3d->tfu_job); > > > + WARN_ON(v3d->csd_job); > > > > I guess we should do this for cache clean jobs too, right? > > As the cache clean jobs are synchronous, we don't keep track of the > current cache clean job. When I say that the cache clean jobs are > synchronous, it means that the end of the job is not determined by > an interruption. Therefore, there is no need to make sure that the > cache clean jobs are still running. I see, thanks Maíra. Reviewed-by: Iago Toral Quiroga <itoral@xxxxxxxxxx> > > Best Regards, > - Maíra > > > > > Iago > > > > > > > > drm_mm_takedown(&v3d->mm); > > > > > >
