On 10/25/2023 4:53 PM, Andi Shyti wrote:
Hi Nirmoy,
+static inline struct drm_i915_private *guc_to_i915(struct intel_guc *guc)
+{
+ return guc_to_gt(guc)->i915;
+}
+
We don't want inline functions in headers files[1]. Otherwise the series
looks fine to me:
the reason for that patch is that we were including the
i915_drv.h just for that inline function and we were doing it
inside the gt/.
In this patch I am not changing any header dependency.
Sounds fair, thanks,
Nirmoy
I guess the original idea from Matt was to have a generic network
of intel_gt_needs_wa_xxx(), but it didn't develop further.
Reviewed-by: Nirmoy Das <nirmoy.das@xxxxxxxxx>
Thanks,
Andi
