On Wed, 25 Oct 2023 at 10:35, Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote: > > Add DSI Controller version 2.8.0 support for the SM8650 platform. > > Signed-off-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > --- > drivers/gpu/drm/msm/dsi/dsi_cfg.c | 17 +++++++++++++++++ > drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + > 2 files changed, 18 insertions(+) > > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > index 1f98ff74ceb0..10ba7d153d1c 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > @@ -190,6 +190,21 @@ static const struct msm_dsi_config sm8550_dsi_cfg = { > }, > }; > > +static const struct regulator_bulk_data sm8650_dsi_regulators[] = { > + { .supply = "vdda", .init_load_uA = 16600 }, /* 1.2 V */ Same comment regarding uA and sm8550 cfg. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > +}; > + > +static const struct msm_dsi_config sm8650_dsi_cfg = { > + .io_offset = DSI_6G_REG_SHIFT, > + .regulator_data = sm8650_dsi_regulators, > + .num_regulators = ARRAY_SIZE(sm8650_dsi_regulators), > + .bus_clk_names = dsi_v2_4_clk_names, > + .num_bus_clks = ARRAY_SIZE(dsi_v2_4_clk_names), > + .io_start = { > + { 0xae94000, 0xae96000 }, > + }, > +}; > + > static const struct regulator_bulk_data sc7280_dsi_regulators[] = { > { .supply = "vdda", .init_load_uA = 8350 }, /* 1.2 V */ > { .supply = "refgen" }, > @@ -281,6 +296,8 @@ static const struct msm_dsi_cfg_handler dsi_cfg_handlers[] = { > &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops}, > {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_7_0, > &sm8550_dsi_cfg, &msm_dsi_6g_v2_host_ops}, > + {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_8_0, > + &sm8650_dsi_cfg, &msm_dsi_6g_v2_host_ops}, > }; > > const struct msm_dsi_cfg_handler *msm_dsi_cfg_get(u32 major, u32 minor) > diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h b/drivers/gpu/drm/msm/dsi/dsi_cfg.h > index 43f0dd74edb6..4c9b4b37681b 100644 > --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h > +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h > @@ -28,6 +28,7 @@ > #define MSM_DSI_6G_VER_MINOR_V2_5_0 0x20050000 > #define MSM_DSI_6G_VER_MINOR_V2_6_0 0x20060000 > #define MSM_DSI_6G_VER_MINOR_V2_7_0 0x20070000 > +#define MSM_DSI_6G_VER_MINOR_V2_8_0 0x20080000 > > #define MSM_DSI_V2_VER_MINOR_8064 0x0 > > > -- > 2.34.1 > -- With best wishes Dmitry