Dan Carpenter <dan.carpenter@xxxxxxxxxx> writes:
Hello Dan,
> Hello Javier Martinez Canillas,
>
> The patch fdd591e00a9c: "drm/ssd130x: Add support for the SSD132x
> OLED controller family" from Oct 14, 2023 (linux-next), leads to the
> following Smatch static checker warning:
>
> drivers/gpu/drm/solomon/ssd130x.c:921 ssd132x_primary_plane_atomic_check()
> error: uninitialized symbol 'crtc_state'.
>
> drivers/gpu/drm/solomon/ssd130x.c
> 905 static int ssd132x_primary_plane_atomic_check(struct drm_plane *plane,
> 906 struct drm_atomic_state *state)
> 907 {
> 908 struct drm_device *drm = plane->dev;
> 909 struct ssd130x_device *ssd130x = drm_to_ssd130x(drm);
> 910 struct drm_plane_state *plane_state = drm_atomic_get_new_plane_state(state, plane);
> 911 struct ssd130x_plane_state *ssd130x_state = to_ssd130x_plane_state(plane_state);
> 912 struct drm_crtc *crtc = plane_state->crtc;
> 913 struct drm_crtc_state *crtc_state;
> 914 const struct drm_format_info *fi;
> 915 unsigned int pitch;
> 916 int ret;
> 917
> 918 if (crtc)
> 919 crtc_state = drm_atomic_get_new_crtc_state(state, crtc);
>
> crtc_state is not initialized
>
Indeed. Thanks a lot for reporting this.
I'll post a fix.
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
