Am Donnerstag, 19. Oktober 2023, 11:21:47 CEST schrieb Krzysztof Kozlowski: > On 18/10/2023 18:18, Chris Morgan wrote: > > From: Chris Morgan <macromorgan@xxxxxxxxxxx> > > > > The Powkiddy RK2023 is a handheld gaming device made by Powkiddy and > > powered by the Rockchip RK3566 SoC. > > > > Signed-off-by: Chris Morgan <macromorgan@xxxxxxxxxxx> > > --- > > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > > index a349bf4da6bc..a6612185a7ff 100644 > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > > @@ -674,6 +674,11 @@ properties: > > - const: powkiddy,rgb30 > > - const: rockchip,rk3566 > > > > + - description: Powkiddy RK2023 > > + items: > > + - const: powkiddy,rk2023 > > This cuold be just enum in previous entry :/ but I remember we talked > about this once with Heiko. Keeping similar devices together is perfectly fine. Like we do for example with the Rock PI 4A/4A+/B/B+/C family directly below. The powkiddy,rk2023 really looks like very similar to the rgb30, so could do something similar. The variant I don't like is having one big enum for _all_ boards using the same soc. Heiko > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > > + - const: rockchip,rk3566 > > > > Best regards, > Krzysztof > >