On 17/10/2023 10:31, Thomas Zimmermann wrote:
Update the names of ast's VGA registers to follow the documentation and put all constants into a separate header. The update make the driver source code more grep-able. No functional changes.
I think the previous name is more meaningful than the one from the documentation. But I agree it's better to match the documentation.
For the whole series: Reviewed-by: Jocelyn Falempe <jfalempe@xxxxxxxxxx> -- Jocelyn
Thomas Zimmermann (12): drm/ast: Rename AST_IO_AR_PORT_WRITE to AST_IO_VGAARI_W drm/ast: Rename AST_IO_MISC_PORT_WRITE to AST_IO_VGAMR_W drm/ast: Rename AST_IO_VGA_ENABLE_PORT to AST_IO_VGAER drm/ast: Rename AST_IO_SEQ_PORT to AST_IO_VGASRI drm/ast: Rename AST_IO_DAC_INDEX_READ to AST_IO_VGADRR drm/ast: Rename AST_IO_DAC_INDEX_WRITE to AST_IO_VGADWR drm/ast: Rename AST_IO_DAC_DATA to AST_IO_VGAPDR drm/ast: Rename AST_IO_GR_PORT to AST_IO_VGAGRI drm/ast: Rename AST_IO_CRTC_PORT to AST_IO_VGACRI drm/ast: Rename AST_IO_INPUT_STATUS1_READ to AST_IO_VGAIR1_R drm/ast: Rename AST_IO_MISC_PORT_READ to AST_IO_VGAMR_R drm/ast: Move register constants to ast_reg.h drivers/gpu/drm/ast/ast_dp.c | 70 +++++------ drivers/gpu/drm/ast/ast_dp501.c | 38 +++--- drivers/gpu/drm/ast/ast_drv.h | 83 +------------ drivers/gpu/drm/ast/ast_i2c.c | 20 ++-- drivers/gpu/drm/ast/ast_main.c | 24 ++-- drivers/gpu/drm/ast/ast_mm.c | 4 +- drivers/gpu/drm/ast/ast_mode.c | 200 ++++++++++++++++---------------- drivers/gpu/drm/ast/ast_post.c | 26 ++--- drivers/gpu/drm/ast/ast_reg.h | 99 ++++++++++++++++ 9 files changed, 292 insertions(+), 272 deletions(-) create mode 100644 drivers/gpu/drm/ast/ast_reg.h
