Hi Chris, Am Montag, 16. Oktober 2023, 20:26:58 CEST schrieb Chris Morgan: > On Mon, Oct 16, 2023 at 08:18:25PM +0200, Heiko Stübner wrote: > > Hi, > > > > Am Montag, 16. Oktober 2023, 18:07:52 CEST schrieb Dragan Simic: > > > On 2023-10-16 17:52, Chris Morgan wrote: > > > > Confirmed that those pending patches DO fix the panel suspend issues. > > > > Thank you. > > > > > > Awesome, that's great to hear! Perhaps a "Tested-by" in the original > > > LKML thread [1] could help with having the patch pulled sooner. > > > > > > Links: > > > [1] > > > https://lore.kernel.org/lkml/33b72957-1062-1b66-85eb-c37dc5ca259b@xxxxxxxxxx/T/ > > > > > > > > > > On Mon, Oct 16, 2023 at 3:41 AM Guido Günther <guido.gunther@xxxxxxx> > > > > wrote: > > > >> > > > >> Hi Chris, > > > >> On Fri, Oct 13, 2023 at 01:39:16PM -0500, Chris Morgan wrote: > > > >> > From: Chris Morgan <macromorgan@xxxxxxxxxxx> > > > >> > > > > >> > The Powkiddy RGB30 4 inch panel is a 4 inch 720x720 DSI panel used in > > > >> > the Powkiddy RGB30 handheld gaming device. Add support for it. > > > >> > > > > >> > TODO: The panel seems to not resume properly from suspend. I've > > > >> > confirmed on the other ST7703 based devices it works correctly. > > > > so this TODO item could go away, right? > > I can remove it when applying the patch, just want to make sure > > all review comments are addressed - only the suspend thing it seems. > > That is correct, but let me send a v2 of this instead. I'll remove this > verbiage among other fixes. End users wanted me to see if I could get > this panel to run at precisely 60hz, which I believe I am able to do > with the addition of a new PLL clock in clk_rk3568. I believe I have > taken every constraint detailed in the datasheet to heart for the new > frequency I'll be requesting. By using the frequency of 292500000 for > the VPLL I can get the panel running at 59.969hz which in my view is > close enough to the ideal 59.98hz. > > I also accidentally left the UART2 active even though this device has > no exposed UART port, so I need to fix that too by disabling it. > > Lastly I'll add my tested by to the dri-devel patches as well. too late ;-) Looks like your mail and me applying the series happened at a similar time and I just saw your mail. So if you want to change the dts now, please do a followup patch. Thanks Heiko
