Hi Arnd, > static void rc6_res_reg_init(struct intel_rc6 *rc6) > { > - memset(rc6->res_reg, INVALID_MMIO_REG.reg, sizeof(rc6->res_reg)); This is a complex initialization, indeed... how about just memset(rc6->res_reg, 0, sizeof(rc6->res_reg)); > + i915_reg_t res_reg[INTEL_RC6_RES_MAX] = { > + [0 ... INTEL_RC6_RES_MAX - 1] = INVALID_MMIO_REG, > + }; This is basically a i915_reg_t res_reg[INTEL_RC6_RES_MAX] = { }; Don't know which one is clearer. Andi