On 2023-10-16 11:29, Luben Tuikov wrote: > On 2023-10-16 11:12, Matthew Brost wrote: >> On Sat, Oct 14, 2023 at 08:09:31PM -0400, Luben Tuikov wrote: >>> On 2023-10-13 22:49, Luben Tuikov wrote: >>>> On 2023-10-11 19:58, Matthew Brost wrote: >>>>> Rather than call free_job and run_job in same work item have a dedicated >>>>> work item for each. This aligns with the design and intended use of work >>>>> queues. >>>>> >>>>> v2: >>>>> - Test for DMA_FENCE_FLAG_TIMESTAMP_BIT before setting >>>>> timestamp in free_job() work item (Danilo) >>>>> v3: >>>>> - Drop forward dec of drm_sched_select_entity (Boris) >>>>> - Return in drm_sched_run_job_work if entity NULL (Boris) >>>>> v4: >>>>> - Replace dequeue with peek and invert logic (Luben) >>>>> - Wrap to 100 lines (Luben) >>>>> - Update comments for *_queue / *_queue_if_ready functions (Luben) >>>>> >>>>> Signed-off-by: Matthew Brost <matthew.brost@xxxxxxxxx> >>>> >>>> I wasn't able to apply this patch on top of drm-misc-next at a48e2cc92835fa. >>>> >>>> Create a branch off of a *clean* drm-misc-next and rebase/reapply/cherry-pick all >>>> 7 patches on top of that clean drm-misc-next branch. You should also run >>>> scripts/checkpatch.pl --strict on all your patches, or integrate it into the precommit >>>> hook, see githooks(5), so you don't have to run it manually. >>>> >>>> Set format.useAutobase to whenAble somewhere in your Git configs (global/local), >>>> or use --base=auto to git-format-patch when you format your patches before >>>> git-send-email-ing them. >>>> >>>> Repost your patches. >>>> >>>> The base commit will be added to the bottom of the cover letter. It should >>>> be an ancestor (or tip) of drm-misc-next (git branch --contains <base> --list etc.). >>>> If it is not, your base tree wasn't clean, and you should redo this process. >>> >>> Poking around I found out that this patch set is based off of drm-misc-fixes. >>> Had the base been included, it would've made this easier. >> >> I believe I based this off of drm-tip. Will follow the flow mentioned above in next rev. > > Sure. You can use drm-tip, drm-misc-next, drm-misc-fixes, just make sure --base=auto > is set as outlined above, and if you're including a cover letter (a free format text), > you can mention the base branch in there too, even though useAutobase has included the SHA, > it makes it easier. Using -fixes or -tip is better as it includes Christian's dma_fence_timestamp() helper, and we want that in. -- Regards, Luben
