On Wed, 11 Oct 2023 11:01:48 +0300, Dan Carpenter wrote: > The "ret" variable is declared as ssize_t and it can hold negative error > codes but the "rk_obj->base.size" variable is type size_t. This means > that when we compare them, they are both type promoted to size_t and the > negative error code becomes a high unsigned value and is treated as > success. Add a cast to fix this. > > > [...] Applied, thanks! [1/1] drm/rockchip: Fix type promotion bug in rockchip_gem_iommu_map() commit: 6471da5ee311d53ef46eebcb7725bc94266cc0cf Best regards, -- Heiko Stuebner <heiko@xxxxxxxxx>