On Fri, Oct 13, 2023 at 02:43:31PM +0800, Andy Yan wrote: > Hi Sacha: > > On 10/13/23 14:11, Sascha Hauer wrote: > > On Thu, Oct 12, 2023 at 10:37:05AM +0800, Andy Yan wrote: > > > From: Andy Yan <andy.yan@xxxxxxxxxxxxxx> > > > > > > The cluster windows on rk3568/6 only support afbc format, > > > linear format(RGB/YUV) are not supported. > > > The cluster windows on rk3588 support both linear and afbc rgb > > > format, but for yuv format it only support afbc. > > > > > > The esmart windows on rk3588 support uv swap for yuyv, but > > > rk356x does not support it. > > It's a bit hard to track which sentence in the description refers to > > which change in the patch. Could you split this up into multiple patches > > to make this easier reviewable? > > > > Renaming of the formats could also be a separate patch. Patches marked > > with "no functional change" are nice and easy to review. > > > How do you like if I split the patch like bellow: > > PATCH 1 : fix the format When you say "The cluster windows on rk3568/6 only support afbc format, ..." and "The esmart windows on rk3588 support uv swap for yuyv, ..." it sounds like two orthogonal changes which should be done in two patches. > > PATCH 2: rename: s/formats_win_full_10bit/formats_cluster/ > > s/formats_win_full_10bit_yuyv/formats_rk356x_esmart/ > > s/formats_win_little/formats_win_smart/ I'd likely do the rename first, but I guess that's just a matter of taste. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
