On Thu, 12 Oct 2023, Jean Delvare <jdelvare@xxxxxxxx> wrote: > On Mon, 2023-10-09 at 16:14 -0500, Lakshmi Yadlapati wrote: >> Signed-off-by: Lakshmi Yadlapati <lakshmiy@xxxxxxxxxx> >> --- >> drivers/i2c/i2c-core-base.c | 8 +- >> drivers/i2c/i2c-core-smbus.c | 143 ++++++++++++++++++++++++++++------- >> drivers/i2c/i2c-core.h | 23 ++++++ >> include/linux/i2c.h | 2 + >> 4 files changed, 145 insertions(+), 31 deletions(-) >> (...) > > Non-trivial patch with no description -> not even looking, sorry. You > can't possibly propose a change to the core of a subsystem and not > bother explaining why this change is needed or what purpose it serves. We've even managed to write extensive documentation on this! https://docs.kernel.org/process/submitting-patches.html#describe-your-changes > > (And yes I know there's some information in patch 0/2, but that's not > going to make it into git, so it will be lost. Commits should be self- > sufficient, not only the implementation, but also the description.) > > I would also suggest trimming the To and Cc lists. I can't really see > how linux-media and dri-devel are relevant here for example. -- Jani Nikula, Intel
