Hi, On Tue, Oct 10, 2023 at 10:42 PM cong yang <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > Hi, > > On Wed, Oct 11, 2023 at 3:11 AM Doug Anderson <dianders@xxxxxxxxxx> wrote: > > > > Hi, > > > > On Tue, Oct 10, 2023 at 5:14 AM Cong Yang > > <yangcong5@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > > > > > > diff --git a/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c > > > new file mode 100644 > > > index 000000000000..e095ad91c4bc > > > --- /dev/null > > > +++ b/drivers/gpu/drm/panel/panel-ilitek-ili9882t.c > > > @@ -0,0 +1,762 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Panels based on the Ilitek ILI9882T display controller. > > > + */ > > > +#include <linux/delay.h> > > > +#include <linux/gpio/consumer.h> > > > +#include <linux/module.h> > > > +#include <linux/of.h> > > > +#include <linux/of_device.h> > > > > nit: remove include of linux/of_device.h since you don't use any of > > the functions declared there. > > It seems that of_device_get_match_data will be used. Right... ...and of_device_get_match_data() is declared in... <linux/of.h>. :-) See commit 82174a0a9c5c ("of: Move of_device_get_match_data() declaration") and commit 722d4f06e560 ("drm: Explicitly include correct DT includes"). We'll probably need to handle that when picking to downstream, but for upstream you shouldn't be re-introducing of_device.h. -Doug