Re: [PATCH] drm/i915: Prevent potential UAF in engine_init_common

[Nirmoy Das <nirmoy.das@xxxxxxxxx>]

Hi Andi,

On 10/11/2023 2:22 PM, Andi Shyti wrote:
> Hi Nirmoy,
>
> On Wed, Oct 11, 2023 at 01:54:51PM +0200, Nirmoy Das wrote:
> > If measure_breadcrumb_dw() returns an error and bce isn't created,
> > this commit ensures that intel_engine_destroy_pinned_context()
> > is not called with a NULL bce.
> >
> > Fixes: b35274993680 ("drm/i915: Create a kernel context for GGTT updates")
> > Cc: Oak Zeng <oak.zeng@xxxxxxxxx>
> > Cc: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>
> > Signed-off-by: Nirmoy Das <nirmoy.das@xxxxxxxxx>
> Reviewed-by: Andi Shyti <andi.shyti@xxxxxxxxxxxxxxx>

Resent with a fixed subject. Please check again.


Thanks,

Nirmoy

> Andi