Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> writes: > Hi Javier, > > On Mon, Oct 9, 2023 at 8:36 PM Javier Martinez Canillas > <javierm@xxxxxxxxxx> wrote: >> Don't assume bpp of 1 and instead compute the destination pitch using the >> intermediate buffer pixel format info when doing a format conversion. >> >> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> > > Thanks for your patch! > >> --- a/drivers/gpu/drm/solomon/ssd13xx.c >> +++ b/drivers/gpu/drm/solomon/ssd13xx.c >> @@ -148,6 +148,8 @@ struct ssd13xx_plane_state { >> struct drm_shadow_plane_state base; >> /* Intermediate buffer to convert pixels from XRGB8888 to HW format */ >> u8 *buffer; >> + /* Pixel format info for the intermediate buffer */ >> + const struct drm_format_info *fi; > > This is really intermediate, as it is removed again in the next patch :-) > > In fact 60% of this patch is changed again in the next patch. > So perhaps combine this with the next patch? > I actually had it like that but then thought that maybe someone would say that should be a separate patch :) I will squash it then. > Gr{oetje,eeting}s, > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat