On Tue, Oct 10, 2023 at 06:20:03PM +0800, Dmitry Osipenko wrote: > Hi, > > On 10/10/23 06:25, Huang Rui wrote: > > These definitions are used fro qemu, and qemu imports this marco in the > > headers to enable gfxstream or venus for virtio gpu. So it should add it > > even kernel doesn't use this. > > > > Signed-off-by: Huang Rui <ray.huang@xxxxxxx> > > --- > > > > Changes V1 -> V2: > > - Add all capsets including gfxstream and venus in kernel header (Dmitry Osipenko) > > > > v1: https://lore.kernel.org/lkml/20230915105918.3763061-1-ray.huang@xxxxxxx/ > > > > include/uapi/linux/virtio_gpu.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/include/uapi/linux/virtio_gpu.h b/include/uapi/linux/virtio_gpu.h > > index f556fde07b76..327792658bdc 100644 > > --- a/include/uapi/linux/virtio_gpu.h > > +++ b/include/uapi/linux/virtio_gpu.h > > @@ -309,6 +309,8 @@ struct virtio_gpu_cmd_submit { > > > > #define VIRTIO_GPU_CAPSET_VIRGL 1 > > #define VIRTIO_GPU_CAPSET_VIRGL2 2 > > +#define VIRTIO_GPU_CAPSET_GFXSTREAM 3 > > +#define VIRTIO_GPU_CAPSET_VENUS 4 > > > > /* VIRTIO_GPU_CMD_GET_CAPSET_INFO */ > > struct virtio_gpu_get_capset_info { > > By the "all" capsets, I meant to pick up all definitions from crosvm. > There should be VIRTIO_GPU_CAPSET_DRM at minimum, could you please add it? > Sure. Thanks for the reminder. Best Regards, Ray