Thomas Zimmermann <tzimmermann@xxxxxxx> writes: Hello Thomas, > Store an instance of struct drm_format_conv_state in the shadow-plane > state struct drm_shadow_plane_state. Many drivers with shadow planes > use DRM's format helpers to copy or convert the framebuffer data to > backing storage in the scanout buffer. The shadow plane provides the > necessary state and manages the conversion's intermediate buffer memory. > I would argue this is one of the primary selling points for this series (since Maxime was asking about the motivation). As you point out, many drivers that use a shadow-buffer can also expose a different format than the native one to user-space, so makes sense to have the buffer used for conversion as a part of the shadow-plane state. Just mentioning this because you are not including that in the paragraph talking about the motivation for the patch series in its cover letter. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat
