The dpu_encoder_phys_ops::atomic_mode_set() callback is mostly redundant. Implementations only set the IRQ indices there. Move statically allocated IRQs to dpu_encoder_phys_*_init() and set dynamically allocated IRQs in the irq_enable() callback. Changes since v1: - Split trace events into enable/disable pairs (Abhinav). Dmitry Baryshkov (3): drm/msm/dpu: split irq_control into irq_enable and _disable drm/msm/dpu: split _dpu_encoder_resource_control_helper() drm/msm/dpu: drop dpu_encoder_phys_ops.atomic_mode_set drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c | 79 +++++++++++----- .../gpu/drm/msm/disp/dpu1/dpu_encoder_phys.h | 11 +-- .../drm/msm/disp/dpu1/dpu_encoder_phys_cmd.c | 93 +++++++++---------- .../drm/msm/disp/dpu1/dpu_encoder_phys_vid.c | 57 ++++++------ .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 34 +++---- drivers/gpu/drm/msm/disp/dpu1/dpu_trace.h | 74 +++++++++++---- 6 files changed, 204 insertions(+), 144 deletions(-) -- 2.39.2