Re: [PATCH 2/2] backlight: Add Kinetic KTD2801 driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday, October 5, 2023 10:40:41 PM CEST Krzysztof Kozlowski wrote:
> On 05/10/2023 20:49, Duje Mihanović wrote:
> > +	gpiod_set_value(ktd2801->desc, 0);
> > +	udelay(EOD_H);
> 
> Hm, why device is kept off after this? Setting 0 means enable GPIO is
> logical 0.
...
> > +	ktd2801->desc = devm_gpiod_get(dev, "enable", GPIOD_OUT_LOW);
> 
> OUT_LOW is keep it disabled, so is this intentional?

I initially wrote the driver to expect GPIO_ACTIVE_LOW, a decision which in 
retrospect indeed makes no sense. If you have no objections, I'll change it to 
expect GPIO_ACTIVE_HIGH.

Regards,
Duje








[Index of Archives]     [Linux DRI Users]     [Linux Intel Graphics]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]
  Powered by Linux