On 10/3/23 14:09, Boris Brezillon wrote: > Unmap tends to refer to a VM related operation (removing a mapping in > the CPU or GPU VM), so it's confusing too IMHO. What we do here is > return pages to the shmem file logic, so they can be reclaimed. > > Given the drm_gem function doing that is called drm_gem_put_pages(), > maybe rename it drm_gem_shmem_shrinker_put_pages_locked(), and rename > drm_gem_shmem_swapin_locked() into > drm_gem_shmem_shrinker_get_pages_locked(), to be consistent. The swapin is a common term and function naming scheme among DRM drivers. That name shouldn't be changed. The drm_gem_shmem_shrinker_put_pages_locked() sounds okay, let's use it. -- Best regards, Dmitry
